Skip to content

replace milind to yuedong for qe members#76501

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
huali9:addyuedong
Mar 20, 2026
Merged

replace milind to yuedong for qe members#76501
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
huali9:addyuedong

Conversation

@huali9
Copy link
Contributor

@huali9 huali9 commented Mar 19, 2026

refer #31927, replace milind to yuedong as a secondary cherry pick approver. @sunzhaohua2 @lunarwhite PTAL, thanks.

liuhuali@Lius-MacBook-Pro release % make prow-config
false || docker pull --platform linux/amd64 quay.io/openshift/ci-public:ci_auto-config-brancher_latest
ci_auto-config-brancher_latest: Pulling from openshift/ci-public
1174ed37633c: Already exists 
1370def9c30e: Pull complete 
Digest: sha256:028ab448bed2947f8e474b68df192b6488dc0032096f76bf312934829c0b32da
Status: Downloaded newer image for quay.io/openshift/ci-public:ci_auto-config-brancher_latest
quay.io/openshift/ci-public:ci_auto-config-brancher_latest
docker run --platform linux/amd64 --user 501:20 --rm -v "/Users/liuhuali/project/release/core-services/prow/02_config:/config:z" --entrypoint=/usr/bin/determinize-prow-config quay.io/openshift/ci-public:ci_auto-config-brancher_latest --prow-config-dir /config --sharded-prow-config-base-dir /config --sharded-plugin-config-base-dir /config
liuhuali@Lius-MacBook-Pro release %

@openshift-ci openshift-ci bot requested review from chrischdi and damdo March 19, 2026 02:23
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 19, 2026
@huali9
Copy link
Contributor Author

huali9 commented Mar 19, 2026

/assign @damdo

damdo
damdo reviewed Mar 19, 2026
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Welcome!

@lunarwhite
Copy link
Member

lunarwhite commented Mar 19, 2026

Thanks both!

I'm wondering if we can safely drop below section from each repo going forward, since cherry-pick-approved labeling restriction was included to support an old process

- allowed_users:
      - <QE member>
      assign_on:
      - label: backport-risk-assessed
      label: cherry-pick-approved

https://redhat-internal.slack.com/archives/GE2HQ9QP4/p1773910211759879

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Mar 19, 2026

/approve

@damdo
Copy link
Member

damdo commented Mar 19, 2026

We need approval from @elmiko

too

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 20, 2026

[REHEARSALNOTIFIER]
@huali9: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2026

@huali9: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@huali9
Copy link
Contributor Author

huali9 commented Mar 20, 2026

Since autoscaler isn't our responsibility anymore, I've reverted the autoscaler file. It should be good now.

@sunzhaohua2
Copy link
Contributor

sunzhaohua2 commented Mar 20, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, huali9, JoelSpeed, sunzhaohua2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4d4a332 into openshift:main Mar 20, 2026
10 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 20, 2026

@huali9: Updated the plugins configmap in namespace ci at cluster app.ci using the following files:

  • key core-services-prow-02_config-openshift-azure-service-operator-_pluginconfig.yaml using file core-services/prow/02_config/openshift/azure-service-operator/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cloud-provider-alibaba-cloud-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cloud-provider-alibaba-cloud/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cloud-provider-aws-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cloud-provider-aws/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cloud-provider-azure-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cloud-provider-azure/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cloud-provider-gcp-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cloud-provider-gcp/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cloud-provider-ibm-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cloud-provider-ibm/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cloud-provider-nutanix-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cloud-provider-nutanix/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cloud-provider-vpc-controller-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cloud-provider-vpc-controller/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cloud-provider-vsphere-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cloud-provider-vsphere/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-api-actuator-pkg-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-api-actuator-pkg/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-api-operator-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-api-operator/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-api-provider-alibaba-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-api-provider-alibaba/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-api-provider-aws-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-api-provider-aws/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-api-provider-azure-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-api-provider-azure/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-api-provider-gcp-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-api-provider-gcp/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-api-provider-ibmcloud-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-api-provider-ibmcloud/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-api-provider-nutanix-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-api-provider-nutanix/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-api-provider-openshift-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-api-provider-openshift/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-api-provider-vsphere-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-api-provider-vsphere/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-api-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-api/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-autoscaler-operator-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-autoscaler-operator/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-capi-operator-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-capi-operator/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-cloud-controller-manager-operator-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-cloud-controller-manager-operator/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-control-plane-machine-set-operator-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-control-plane-machine-set-operator/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-cluster-machine-approver-_pluginconfig.yaml using file core-services/prow/02_config/openshift/cluster-machine-approver/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-machine-api-operator-_pluginconfig.yaml using file core-services/prow/02_config/openshift/machine-api-operator/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-machine-api-provider-aws-_pluginconfig.yaml using file core-services/prow/02_config/openshift/machine-api-provider-aws/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-machine-api-provider-azure-_pluginconfig.yaml using file core-services/prow/02_config/openshift/machine-api-provider-azure/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-machine-api-provider-gcp-_pluginconfig.yaml using file core-services/prow/02_config/openshift/machine-api-provider-gcp/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-machine-api-provider-ibmcloud-_pluginconfig.yaml using file core-services/prow/02_config/openshift/machine-api-provider-ibmcloud/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-machine-api-provider-nutanix-_pluginconfig.yaml using file core-services/prow/02_config/openshift/machine-api-provider-nutanix/_pluginconfig.yaml
  • key core-services-prow-02_config-openshift-machine-api-provider-powervs-_pluginconfig.yaml using file core-services/prow/02_config/openshift/machine-api-provider-powervs/_pluginconfig.yaml
Details

In response to this:

refer #31927, replace milind to yuedong as a secondary cherry pick approver. @sunzhaohua2 @lunarwhite PTAL, thanks.

liuhuali@Lius-MacBook-Pro release % make prow-config
false || docker pull --platform linux/amd64 quay.io/openshift/ci-public:ci_auto-config-brancher_latest
ci_auto-config-brancher_latest: Pulling from openshift/ci-public
1174ed37633c: Already exists 
1370def9c30e: Pull complete 
Digest: sha256:028ab448bed2947f8e474b68df192b6488dc0032096f76bf312934829c0b32da
Status: Downloaded newer image for quay.io/openshift/ci-public:ci_auto-config-brancher_latest
quay.io/openshift/ci-public:ci_auto-config-brancher_latest
docker run --platform linux/amd64 --user 501:20 --rm -v "/Users/liuhuali/project/release/core-services/prow/02_config:/config:z" --entrypoint=/usr/bin/determinize-prow-config quay.io/openshift/ci-public:ci_auto-config-brancher_latest --prow-config-dir /config --sharded-prow-config-base-dir /config --sharded-plugin-config-base-dir /config
liuhuali@Lius-MacBook-Pro release %

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

1 more reviewer

@damdo damdo damdo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@damdo damdo

@sunzhaohua2 sunzhaohua2

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@huali9 @lunarwhite @JoelSpeed @damdo @openshift-ci-robot @sunzhaohua2